Reviewer's Guide

Adjusts the future-dated subscription manifest fixture to only provide manifest content and moves the manifest upload into the specific UI test so the test explicitly controls when and where the manifest is uploaded.

Sequence diagram for future-dated subscription manifest upload in UI test

sequenceDiagram
    actor Tester
    participant Pytest as PytestRunner
    participant Test as test_positive_populate_future_date_subcription
    participant Fixture as func_future_dated_subscription_manifest
    participant Manifester as Manifester
    participant TargetSat as target_sat
    participant Satellite as SatelliteServer

    Tester ->> Pytest: run tests/foreman/ui/test_subscription.py
    Pytest ->> Test: execute test_positive_populate_future_date_subcription

    Test ->> Fixture: request func_future_dated_subscription_manifest
    activate Fixture
    Fixture ->> Manifester: __enter__(manifest_category=future_date_subscription)
    activate Manifester
    Manifester -->> Fixture: manifest (with content)
    Fixture -->> Test: yield manifest
    deactivate Manifester
    deactivate Fixture

    Note over Test,TargetSat: Manifest upload is now explicitly controlled by the test

    Test ->> TargetSat: upload_manifest(function_org.id, manifest.content)
    activate TargetSat
    TargetSat ->> Satellite: store manifest for organization
    Satellite -->> TargetSat: manifest stored
    deactivate TargetSat

    Test -->> Pytest: assertions on future-dated subscription UI
    Pytest -->> Tester: test result

File-Level Changes

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.